-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winevulkan: Implement VK_KHR_get_surface_capabilities2 and fake support for VK_EXT_full_screen_exclusive #85
Conversation
…rt for VK_EXT_full_screen_exclusive
Avoids needing a super new loader and breaking everything if one isn't present
You changed the permissions of |
…_capabilities2 support patch with Josh's, which also adds faking VK_EXT_full_screen_exclusive support Rebased against current wine head. ValveSoftware/wine#85 Should be all that's needed for Doom Eternal Vulkan renderer to work: ValveSoftware/Proton#3654 Denuvo is likely still an issue.
This was merged as 76b8510. |
does anyone know why this commit didn't make it to 6.3? I was able to launch the Doom Eternal on Ubuntu only when I found this PR and switched my Proton to 5.0 🙄 |
Hello @spirit-q2, I did a non-comprehensive search and it looks like this was replaced by upstream commits including 086c686 314cd9c. |
I think the fullscreen support part may have gotten dropped. I'm not certain whether those commits you point to are a complete replacement for the surface capabilities part or not. @Joshua-Ashton are you able to take a look? |
I agree, @kisak-valve, that looks like a replacement of this fix, but... if you will take a look here you can see that the I've tried so many variations and combinations to start Doom Eternal (including compiling the latest version of the |
I was looking into restoring this support, but Doom Eternal is working fine for me in current Proton 6.3-7 without it. If we don't know if any games that need it, I'm not sure it's worth carrying a diff for. @spirit-q2, I wonder if the failure you're seeing is unrelated to this change? Can you upload a log of the failure you're seeing with a current Proton release? |
+in_terminal 1 parameter. So it was logs from the Doom itself, not proton's. with Proton - Experimental it looks like this: |
Proton 6.3 : |
Proton 5.0 : |
it also might be related to my version of Doom Eternal... it's not the "steam version", if you know what I mean ;) |
The Bethesda.net version should be updated also, if not you may want to contact Bethesda to see if they are behind on patching on their official launcher. There are no other versions on PC. I don't think anyone here cares about pirated versions or people who are trying to get support for them. |
Hello @spirit-q2, in the future, please use a gist or other pastebin service and share a link or attach logs as a file instead of copy/pasting large blobs of text inline with your comments. |
sure @kisak-valve will do. btw, how did you make them to be collapsed? 🤔 |
You can click on the edit option of your previous comment to see the html trick I used. |
We need this for some upcoming titles.